Create BottomUpReconciliator
#1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1058--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## hierarchical_pipeline #1058 +/- ##
========================================================
Coverage ? 86.48%
========================================================
Files ? 168
Lines ? 8917
Branches ? 0
========================================================
Hits ? 7712
Misses ? 1205
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-hse-repository
suggested changes
Jan 1, 2023
etna/reconciliation/bottom_up.py
Outdated
| if current_level_index < source_level_index: | ||
| raise ValueError("Current TSDataset level should be lower or equal in the hierarchy than the source level!") | ||
|
|
||
| if (ts[..., "target"] < 0).values.any(): |
There was a problem hiding this comment.
This method works correctly with the values of any kind
There was a problem hiding this comment.
Added this check for consistency purpose only. I think in this case we should add info about nonnegative numbers to TopDownReconciliator doc.
There was a problem hiding this comment.
Good idea, may you do it in this PR
alex-hse-repository
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #1037